Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

journal: only destroy the connection if it is set #4904

Merged
merged 1 commit into from
Oct 14, 2024
Merged

journal: only destroy the connection if it is set #4904

merged 1 commit into from
Oct 14, 2024

Conversation

nixpanic
Copy link
Member

@nixpanic nixpanic commented Oct 11, 2024 •
edited
Loading

Prevent re-use of a destroyed connection by setting it to nil. This
way it is also safe to call Destroy() multiple times without causing a
panic.

Found while working on #4502.

@nixpanic nixpanic requested review from Madhu-1 and a team October 11, 2024 08:17
@nixpanic nixpanic mentioned this pull request Oct 11, 2024
Open
@nixpanic nixpanic added the component/journal This PR has a change in volume journal label Oct 11, 2024
@nixpanic nixpanic requested a review from a team October 11, 2024 12:39
@nixpanic
Copy link
Member Author

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 14, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@nixpanic
journal: only destroy the connection if it is set
15b14a2 
Prevent re-use of a destroyed connection by setting it to `nil`. This
way it is also safe to call `Destroy()` multiple times without causing a
panic.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Oct 14, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Oct 14, 2024
@nixpanic
Copy link
Member Author

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 14, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@nixpanic
Copy link
Member Author

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 14, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@nixpanic
Copy link
Member Author

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 14, 2024

rebase

☑️ Nothing to do

  • any of:
    • #commits > 1 [📌 rebase requirement]
    • #commits-behind > 0 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • -conflict [📌 rebase requirement]
  • queue-position = -1 [📌 rebase requirement]

@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Oct 14, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Oct 14, 2024
@nixpanic
Copy link
Member Author

/test ci/centos/upgrade-tests

@nixpanic
Copy link
Member Author

/retest ci/centos/k8s-e2e-external-storage/1.29

@nixpanic
Copy link
Member Author

/retest ci/centos/k8s-e2e-external-storage/1.30

@nixpanic
Copy link
Member Author

/retest ci/centos/k8s-e2e-external-storage/1.31

@nixpanic
Copy link
Member Author

/retest ci/centos/mini-e2e-helm/k8s-1.29

@nixpanic
Copy link
Member Author

/retest ci/centos/mini-e2e-helm/k8s-1.30

@nixpanic
Copy link
Member Author

/retest ci/centos/mini-e2e/k8s-1.29

@nixpanic
Copy link
Member Author

@Mergifyio requeue

Infrastructure issues seem to be resolved.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 14, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@nixpanic
Copy link
Member Author

/retest ci/centos/mini-e2e/k8s-1.29

@nixpanic
Copy link
Member Author

/retest ci/centos/mini-e2e/k8s-1.29

  [FAILED] backend images not matching kubernetes resource count,image count 2 kubernetes resource count 1

logs

@mergify mergify bot merged commit 6df173d into ceph:devel Oct 14, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yati1998 yati1998 yati1998 approved these changes

@iPraveenParihar iPraveenParihar iPraveenParihar approved these changes

@Rakshith-R Rakshith-R Rakshith-R approved these changes

@Madhu-1 Madhu-1 Awaiting requested review from Madhu-1

Assignees
No one assigned
Labels
component/journal This PR has a change in volume journal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nixpanic @ceph-csi-bot @yati1998 @iPraveenParihar @Rakshith-R