Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: resturcture the doc folder #4907

Merged
merged 1 commit into from
Oct 29, 2024
Merged

doc: resturcture the doc folder #4907

merged 1 commit into from
Oct 29, 2024

Conversation

yati1998
Copy link
Contributor

This commit is the restructure the doc folder to
include sub-folders like csi-addons, rbd, cephfs
to contain related docs and other general docs can be placed under doc folder.
This will enhance the doc structure will make it easier for the users to search the docs as it get more populated.

@mergify mergify bot added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/docs Issues and PRs related to documentation labels Oct 14, 2024
@yati1998 yati1998 requested a review from Madhu-1 October 15, 2024 03:44
Copy link
Collaborator

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to move the mount corruption doc to design and same for cephfs snapshot backed volumes as well and for rbd-nbd as well.

we can have a deploy folder for deployments instead of having separate folder in the doc itself.

@Nikhil-Ladha @Rakshith-R any thoughts?

@nixpanic
Copy link
Member

While moving the file into new directories per component, you can remove the redundant component name in the filename. For example:

docs/deploy-rbd.md → docs/rbd/deploy.md

@nixpanic
Copy link
Member

we can have a deploy folder for deployments instead of having separate folder in the doc itself.

I agree if you mean moving the files like this:

docs/deploy-rbd.md → deploy/rbd.md

Possibly add a symlink like docs/rbd/deploy.md pointing to the deploy/rbd.md file.

@Nikhil-Ladha
Copy link
Contributor

Moving to deploy folder and having symlink sounds good!
This way we will have better accessibility.

@Rakshith-R
Copy link
Contributor

we can have a deploy folder for deployments instead of having separate folder in the doc itself.

I agree if you mean moving the files like this:

docs/deploy-rbd.md → deploy/rbd.md

Possibly add a symlink like docs/rbd/deploy.md pointing to the deploy/rbd.md file.

sounds good to me

@@ -0,0 +1 @@
docs/rbd/deploy.md
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accessing symlink failed for me, can you please cross check this and see if you are able to access the file if you open it from deploy folder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, shows error while opening, will check on that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works now, please do review it again

@yati1998
Copy link
Contributor Author

\retest

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Oct 23, 2024

@Mergifyio rebase

Copy link
Contributor

mergify bot commented Oct 23, 2024

rebase

✅ Branch has been successfully rebased

@nixpanic
Copy link
Member

@Mergifyio queue

Copy link
Contributor

mergify bot commented Oct 29, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at a6f1af4

This commit is the restructure the doc folder to
include sub-folders like csi-addons, rbd, cephfs
to contain related docs and other general docs can be
placed under doc folder.
This will enhance the doc structure will make it easier
for the users to search the docs as it get more populated.

Signed-off-by: yati1998 <ypadia@redhat.com>
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Oct 29, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Oct 29, 2024
@mergify mergify bot merged commit a6f1af4 into ceph:devel Oct 29, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/docs Issues and PRs related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants