rados: implement watch/notify APIs #634
Merged
+742
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansiwen
force-pushed
the
pr/ansiwen/watcher
branch
3 times, most recently
from
9364784
to
90f27f7
Compare
ansiwen
force-pushed
the
pr/ansiwen/watcher
branch
from
90f27f7
to
e590a2c
Compare
ansiwen
added
the
API
|
I've given it a quick skim and it generally looks good so far. I'm sure I'll have some more comments when I look deeper but I think it'll be really good to have this. |
phlogistonjohn
requested changes
Feb 4, 2022
|
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
ansiwen
force-pushed
the
pr/ansiwen/watcher
branch
2 times, most recently
from
9ad592e
to
732161e
Compare
|
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
nixpanic
reviewed
Feb 9, 2022
nixpanic
previously approved these changes
Feb 9, 2022
|
@ansiwen you'll need to manually resolve the merge conflicts, unfortortunately |
phlogistonjohn
requested changes
Feb 9, 2022
ansiwen
force-pushed
the
pr/ansiwen/watcher
branch
from
732161e
to
b6ce62a
Compare
mergify
bot
dismissed
nixpanic’s stale review
Pull request has been modified.
ansiwen
force-pushed
the
pr/ansiwen/watcher
branch
from
b6ce62a
to
f3bb7b8
Compare
This change implements the bindings for the watch/notify APIs of librados. Instead of callbacks, the watcher is implemented with more Go-idiomatic channels. A watcher object exposes two read-only channels, one to receive the notify events and one to receive occuring errors. Signed-off-by: Sven Anderson <sven@redhat.com>
Signed-off-by: Sven Anderson <sven@redhat.com>
ansiwen
force-pushed
the
pr/ansiwen/watcher
branch
from
f3bb7b8
to
0d72d0d
Compare
nixpanic
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements the bindings for the watch/notify APIs of
librados. Instead of callbacks, the watcher is implemented with more
Go-idiomatic channels. A watcher object exposes two read-only
channels, one to receive the notify events and one to receive
occuring errors.
Signed-off-by: Sven Anderson sven@redhat.com
Checklist