feat: recon-over-http #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smrz2001
force-pushed
the
feat/http-recon
branch
from
0b944ab
to
bbb24ca
Compare
nathanielc
approved these changes
Nov 3, 2023
nathanielc
reviewed
Nov 9, 2023
recon/src/recon/tests.rs
Outdated
| @@ -544,7 +545,7 @@ async fn response_is_synchronized() { | |||
| let response = a.process_messages(&response.messages).await.unwrap(); | |||
| assert!(!response.is_synchronized); | |||
| let response = x.process_messages(&response.messages).await.unwrap(); | |||
| assert!(!response.is_synchronized); | |||
| assert!(response.is_synchronized); | |||
There was a problem hiding this comment.
Why did this test invert?
There was a problem hiding this comment.
Can you update the test comments if this is expected?
There was a problem hiding this comment.
The is_synchronized logic changed so that it can detect synchronization one round earlier. Now, we don't have to wait for a round where nothing is exchanged so detect that we're done. We're synchronized as soon as the ranges match.
AaronGoldman
force-pushed
the
feat/http-recon
branch
from
5cb5e4e
to
75a1843
Compare
AaronGoldman
force-pushed
the
feat/http-recon
branch
from
75a1843
to
ab2ead2
Compare
This was referenced Jan 22, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 23, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.