fix: trickle publisher keys to swarm #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WS1-1339 DHT flaky tests
We believe the DHT publish logic is starving the swarm task. We should run it on its own task. DOD:
|
Instead of sending all 1000 keys in a batch in one iteration of the swarm loop send one. This way the swarm can continue to process other concurrent work. Tests show this is still fast enough to send out all publish queries within a few seconds.
nathanielc
force-pushed
the
feature/ws1-1339-dht-flaky-tests
branch
from
e8abf1c
to
1838c02
Compare
This was referenced Jan 22, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 23, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of sending all 1000 keys in a batch in one iteration of the swarm loop send one. This way the swarm can continue to process other concurrent work. Tests show this is still fast enough to send out all publish queries within a few seconds.