fix: simplify the publisher #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change the publisher attempted to estimate and amortize the DHT publish load over the entire interval. Now we use a simpler AIMD method and then publish batches without any delay. Additionally no estimate metrics are computed instead two simple metrics of how many remaining records need to be published and the amount of time before the deadline. Now operationally you can estimate the lag, buts the code itself is simpler. Additionally logic was added to not start publishing until kademlia has been bootstrapped.
nathanielc
force-pushed
the
fix/peer_manager
branch
from
8fc5e30
to
3187c3c
Compare
This was referenced Jan 22, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 23, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change the publisher attempted to estimate and amortize the DHT publish load over the entire interval. Now we use a simpler AIMD method and then publish batches without any delay. Additionally no estimate metrics are computed instead two simple metrics of how many remaining records need to be published and the amount of time before the deadline. Now operationally you can estimate the lag, buts the code itself is simpler.
Additionally logic was added to not start publishing until kademlia has been bootstrapped.
Finally the dynamic batch size has been capped to min and max sizes to ensure we always make at least some progress and we have a upper bound (for the internal channel) on how large a batch will get.