fix: upgrade to libp2p 0.53 #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dav1do
reviewed
Dec 5, 2023
smrz2001
approved these changes
Dec 5, 2023
recon/src/libp2p/handler.rs
Outdated
| self.keep_alive | ||
| fn connection_keep_alive(&self) -> bool { | ||
| // Only keep the connection alive if we are not idle | ||
| !matches!(&self.state, State::Idle) | ||
| } | ||
|
|
||
| // TODO(WS1-1345): Remove uses of ConnectionHandler::Error |
There was a problem hiding this comment.
WS1-1345 is also taken care of in this PR, right?
There was a problem hiding this comment.
It does, I have removed this comment and others like it. Thanks
Libp2p has three major features we want: 1. Stable support for QUIC 2. Full tracing support 3. Uses prometheus_client 0.22, this enables use to use tokio-metrics In order to upgrade we needed to address the follow major breaking changes: * KeepAlive is now a boolean signal (bitswap keep alive logic is now much simpler) * Supported Protocols are only known per connection, we now hard code the list for diagnostic reasons There are a few other minor breaking changes but did not affect our code much.
nathanielc
force-pushed
the
fix/libp2p-0.53
branch
from
d74fc11
to
e6b3fa0
Compare
This was referenced Jan 22, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 23, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libp2p has three major features we want:
In order to upgrade we needed to address the follow major breaking changes:
There are a few other minor breaking changes but did not affect our code much.
Closes WS1-1291
Closes WS1-1345