-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Stop publishing CIDs to DHT on write #211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also remove the publisher
and its related logic. Otherwise looks good.
The publisher
lives in p2p/src/publisher.rs
. That whole module can be removed which will result in some changes to node.rs
as well.
Thanks, added (or deleted?). I wasn't sure which of these we wanted to keep for future compatibility, and which we wanted to nuke. Makes sense that the RPC stays, everything else goes. |
60b65f6
to
787025b
Compare
No longer advertising CIDs to DHT
ebe9224
to
88c6e99
Compare
Linear ticket WS1-1400.
Removed CID publishing to the DHT. We still have the RPCs to publish to the DHT (in p2p/rpc.rs and the corresponding beetle client), but we no longer do it on write, and the node no longer has a publisher.