Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Stop publishing CIDs to DHT on write #211

Merged
merged 3 commits into from
Jan 12, 2024
Merged

feat: Stop publishing CIDs to DHT on write #211

merged 3 commits into from
Jan 12, 2024

Conversation

dav1do
Copy link
Contributor

@dav1do dav1do commented Jan 8, 2024

Linear ticket WS1-1400.

Removed CID publishing to the DHT. We still have the RPCs to publish to the DHT (in p2p/rpc.rs and the corresponding beetle client), but we no longer do it on write, and the node no longer has a publisher.

Copy link

linear bot commented Jan 8, 2024

@dav1do dav1do requested a review from nathanielc January 8, 2024 19:16
Copy link
Collaborator

@nathanielc nathanielc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also remove the publisher and its related logic. Otherwise looks good.

The publisher lives in p2p/src/publisher.rs. That whole module can be removed which will result in some changes to node.rs as well.

@dav1do
Copy link
Contributor Author

dav1do commented Jan 8, 2024

We should also remove the publisher and its related logic. Otherwise looks good.

The publisher lives in p2p/src/publisher.rs. That whole module can be removed which will result in some changes to node.rs as well.

Thanks, added (or deleted?). I wasn't sure which of these we wanted to keep for future compatibility, and which we wanted to nuke. Makes sense that the RPC stays, everything else goes.

@dav1do dav1do requested a review from nathanielc January 8, 2024 21:23
Base automatically changed from feature/ws1-1404 to main January 12, 2024 17:18
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants