feat: Add sqlite read/write pool split #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dav1do
commented
Jan 17, 2024
dav1do
requested review from
AaronGoldman and
nathanielc
and removed request for
AaronGoldman
For now, put a basic struct in ceramic_core that manages access to the pools. The sqlx details are not hidden and still relied upon by crates interating with the database.
dav1do
force-pushed
the
feat/ws1-1431-sql-ro
branch
from
3a909a9
to
c6107c2
Compare
dav1do
force-pushed
the
feat/ws1-1431-sql-ro
branch
from
c6107c2
to
d7f1902
Compare
This was referenced Jan 22, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 23, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear ticket WS1-1431.
For now, put a basic struct in ceramic_core that manages access to the pools. The sqlx details are not hidden and still relied upon by crates interacting with the database, as the
sqlx::SqlitePoolis part of the public interface.