feat: Update event types and builder APIs to prevent building events that dont align with the protocol spec #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e rust js-ceramic client" This reverts commit cb53168.
stbrody
commented
May 17, 2024
| // Use self.len() here when we have cid@0.10 | ||
| let buf = Vec::new(); | ||
| let mut writer = std::io::BufWriter::new(buf); | ||
| self.write(&mut writer)?; | ||
| Ok(writer.into_inner()?) | ||
| // safe to unwrap because self.write should never fail. |
There was a problem hiding this comment.
@nathanielc let me know if this is what you had in mind or if there's more I should do to handle this error.
nathanielc
approved these changes
May 17, 2024
| // Use self.len() here when we have cid@0.10 | ||
| let buf = Vec::new(); | ||
| let mut writer = std::io::BufWriter::new(buf); | ||
| self.write(&mut writer)?; | ||
| Ok(writer.into_inner()?) | ||
| // safe to unwrap because self.write should never fail. |
dav1do
approved these changes
May 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.