feat: disallow events with unexpected fields via the http api #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stbrody
commented
May 21, 2024
dav1do
approved these changes
May 22, 2024
stbrody
force-pushed
the
no-unexpected-in-http-api-phase-2
branch
from
87e2fb8
to
b02285e
Compare
Merged
dav1do
pushed a commit
that referenced
this pull request
Jun 4, 2024
* feat: disallow events with unexpected fields via the http api * review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builds on #362.
There was no easy way to unit test this change, but I have a PR ready for a test in ceramic-tests that will exercise this: 3box/ceramic-tests#129