Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modify recon store to support event validation concepts #473

Merged
merged 10 commits into from
Aug 15, 2024

Commits on Aug 13, 2024

  1. Configuration menu
    Copy the full SHA
    06d81f5 View commit details
    Browse the repository at this point in the history
  2. feat: modify recon and store traits to return a struct to return vali…

    …d/invalid item context
    dav1do committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    02c3026 View commit details
    Browse the repository at this point in the history
  3. feat: track and resubmit events from recon when history discovered

    we also explicitly hangup if the store says something is invalid
    dav1do committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    b857f54 View commit details
    Browse the repository at this point in the history
  4. fix: don't derive Hash on types containing recon keys

    this probalby doesn't hurt to include, but we're particular about using our AHash so we'll leave it explicit for now
    dav1do committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    623ec58 View commit details
    Browse the repository at this point in the history
  5. chore: review comments

    - rename InsertBatch -> InsertResult
    - use for loop in pending_cache instead of while loop
    - consistent Self::Key usage in trait
    dav1do committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    2dd6e6b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    82e59d7 View commit details
    Browse the repository at this point in the history
  7. feat: store returns information about event validation

    - recon pending tracking simplified to just retry every batch since we should get items close together
    - fixes a bug where any event in an api batch that was invalid could have crashed the entire batch (now only that one gets an error)
    - TODO: still need to modify the service to have a better validation hook that keeps track of the data we need to return so we don't have to iterate back through or lose info along the way
    dav1do committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    cd34094 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Configuration menu
    Copy the full SHA
    bd43a0d View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Configuration menu
    Copy the full SHA
    af7a6e2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a16d339 View commit details
    Browse the repository at this point in the history