feat: add noop ceramic-olap binary #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ceramic-olap binary copies verbatim some setup code from ceramic-one re tracing/logging/metrics. Eventually this may move back into the ceramic-one binary or we can find a way to make it generic and reuse. Given this is only the first copy of the code I don't think we should work to make it generic yet. Not until we either decide this is the long term home for the ceramic-olap binary or have a third binary we want to have a similar setup. This binary does nothing yet except start tracing/logging/metrics and then wait for a signal to shutdown gracefully.
nathanielc
temporarily deployed
to
github-tests-2024
GitHub Actions
Inactive
|
A lot of metrics for a no-op but looks good. |
nathanielc
temporarily deployed
to
github-tests-2024
GitHub Actions
Inactive
dav1do
approved these changes
Aug 19, 2024
| #[arg( | ||
| short, | ||
| long, | ||
| default_value = "127.0.0.1:9464", |
There was a problem hiding this comment.
I know this is standard, but wondering if we want a different default if we expect c1 and olap to run on one machine?
There was a problem hiding this comment.
Good point, its easy to change later and there might be a few things like that to change.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ceramic-olap binary copies verbatim some setup code from ceramic-one re tracing/logging/metrics. Eventually this may move back into the ceramic-one binary or we can find a way to make it generic and reuse. Given this is only the first copy of the code I don't think we should work to make it generic yet. Not until we either decide this is the long term home for the ceramic-olap binary or have a third binary we want to have a similar setup.
This binary does nothing yet except start tracing/logging/metrics and then wait for a signal to shutdown gracefully.