fix: Fix bug in TimeEvent witness blocks parsing logic #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stbrody
commented
Aug 16, 2024
| @@ -65,8 +64,7 @@ where | |||
| let block_bytes = car_blocks | |||
| .get(cid) | |||
| .ok_or_else(|| anyhow!("Time Event CAR data missing block for path index"))?; | |||
| blocks_in_path.push(block); | |||
There was a problem hiding this comment.
this was the bug. We pushed the block before we updated it, meaning we pushed the first block twice and dropped the last block
stbrody
force-pushed
the
time-event-rt-aes-310
branch
from
e7453f0
to
c538491
Compare
stbrody
temporarily deployed
to
github-tests-2024
GitHub Actions
Inactive
dav1do
reviewed
Aug 16, 2024
dav1do
approved these changes
Aug 16, 2024
stbrody
temporarily deployed
to
github-tests-2024
GitHub Actions
Inactive
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.