feat: jws signature validation #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dav1do
temporarily deployed
to
github-tests-2024
GitHub Actions
Inactive
dav1do
commented
Aug 20, 2024
samika98
approved these changes
Aug 21, 2024
dav1do
commented
Aug 21, 2024
dav1do
force-pushed
the
feat/aes-283-jws-envelope-signature
branch
from
183c85a
to
44c0175
Compare
dav1do
temporarily deployed
to
github-tests-2024
GitHub Actions
Inactive
dav1do
commented
Aug 21, 2024
dav1do
force-pushed
the
feat/aes-283-jws-envelope-signature
branch
3 times, most recently
from
c190dfd
to
c9a89a9
Compare
dav1do
temporarily deployed
to
github-tests-2024
GitHub Actions
Inactive
- use input struct/enum for jws verification (kind of clunky but slightly more clear, maybe?) - add some doc strings/comments - use map_or instead of is_none + unwrap
still missing time parameters for did resolution to be in parity with js-did
dav1do
force-pushed
the
feat/aes-283-jws-envelope-signature
branch
from
c9a89a9
to
ffe6db3
Compare
dav1do
force-pushed
the
feat/aes-283-jws-envelope-signature
branch
from
ffe6db3
to
5a0f598
Compare
dav1do
temporarily deployed
to
github-tests-2024
GitHub Actions
Inactive
dav1do
commented
Aug 26, 2024
dav1do
temporarily deployed
to
github-tests-2024
GitHub Actions
Inactive
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements event validation using did:key/JWS. This verifies the envelope and makes sure the cacao grants access to the key that signed the payload. This builds on #495 (current target) and I had to make the cacao/pkh
Verifierasync since it can be a JWS based on the metadata.This is not invoked anywhere and the tests currently only verify signatures for the valid events from the ceramic-sdk test vectors.