fix: use cacao timestamp strings and parse #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dav1do
temporarily deployed
to
github-tests-2024
GitHub Actions
Inactive
smrz2001
approved these changes
Aug 23, 2024
stbrody
reviewed
Aug 23, 2024
| #[serde(rename = "exp", skip_serializing_if = "Option::is_none")] | ||
| pub expiration: Option<CapabilityTime>, | ||
| pub expiration: Option<String>, |
There was a problem hiding this comment.
Instead of using a raw String and getting no type safety, would it make sense to introduce a new type, that uses string as the underlying storage but provides a method to convert to a DateTime?
There was a problem hiding this comment.
Yeah, it might be nice to use a tuple struct with serde transparent. Or at least make these fields private. I can add something like that in the cacao branch I have open.. wanted to fix it before it got released Monday to avoid any weird issues with event serialization.
There was a problem hiding this comment.
Made the change here: 1d602df
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to ensure that CACAOs round trip without changing the CID, we use a string when deserializing rather than a chrono::DateTime which can change the second precision that was originally included. It's a bit clunky, open to better ideas.