fix: updates detection of tile docs and doesn't log them by default #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
requested review from
stephhuynh18
and removed request for
a team
With this change we catch two more cases where we can detect tile docs. Additionally by default we only count the number of tile docs we find and do not log any errors about them. This way any tile docs do not create a feeling of failure when migrating.
nathanielc
force-pushed
the
fix/tile-doc-ignore
branch
from
b525c62
to
475c0af
Compare
nathanielc
temporarily deployed
to
github-tests-2024
GitHub Actions
Inactive
dav1do
approved these changes
Sep 5, 2024
nathanielc
temporarily deployed
to
github-tests-2024
GitHub Actions
Inactive
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we catch two more cases where we can detect tile docs. Additionally by default we only count the number of tile docs we find and do not log any errors about them. This way any tile docs do not create a feeling of failure when migrating.