fix: start up ordering task bug #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added test to expose problem (fails before, passes now)
was made info during deubgging, maybe merits trace but removing for now
dav1do
temporarily deployed
to
github-tests-2024
GitHub Actions
Inactive
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a recent refactor (released in 0.33), prev was incorrectly set to the init_cid in the startup ordering task. This would have caused events to have been "delivered" in a possibly random order, as everything is after the init event. As this was just introduced and we generally have short streams that should be ordered inline, it is extremely unlikely that it caused any problems that merit a clean up migration (i.e. delete the current value, read all events to rewrite the deliverable order and tell js-ceramic to indexing again) so that is not included.
I also deleted a log statement I accidentally left as info during debugging that shouldn't have landed. It could probably be trace but for now I just removed it as we have prometheus and other metrics around that.