-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support non sharded IPFS block paths #541
Conversation
When migrating from IPFS there are two possible directory structures, a sharded and a non sharded form. This change now supports both defaulting to the sharded form.
/// Sharded paths are organized into a two character prefix directories. | ||
#[arg(long, env = "CERAMIC_ONE_NON_SHARDED_PATHS", default_value_t = false)] | ||
non_sharded_paths: bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, the sharding/key transformations are a configurable property of the blockstore and not a binary choice. But this should cover the "didn't actively configure sharding" case, and the most common option I guess.
https://github.com/ipfs/kubo/blob/master/docs/datastores.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably fine for now. These are the two most likely configs, doubt someone has some other setup, and we could easily change this if someone else does something different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/// Sharded paths are organized into a two character prefix directories. | ||
#[arg(long, env = "CERAMIC_ONE_NON_SHARDED_PATHS", default_value_t = false)] | ||
non_sharded_paths: bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably fine for now. These are the two most likely configs, doubt someone has some other setup, and we could easily change this if someone else does something different.
When migrating from IPFS there are two possible directory structures, a sharded and a non sharded form. This change now supports both defaulting to the sharded form.