refactor: modify eth rpc trait for other chains #550
Merged
+506
−291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dav1do
requested review from
ukstv,
smrz2001,
nathanielc and
samika98
and removed request for
a team
dav1do
temporarily deployed
to
github-tests-2024
GitHub Actions
Inactive
dav1do
temporarily deployed
to
github-tests-2024
GitHub Actions
Inactive
modified EthRpc to be ChainInclusion and only return timestamp and root cid from chain. this required moving a decent amount of logic around parsing chain info/validation from service to validation crate.
stbrody
force-pushed
the
refactor/modify-eth-rpc-trait-for-hoku
branch
from
70fb322
to
b5c388b
Compare
stbrody
temporarily deployed
to
github-tests-2024
GitHub Actions
Inactive
nathanielc
approved these changes
Oct 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the EthRpc trait exposed by the validation crate to hide more chain information and return the specific information needed to do time event validation (a timestamp and a root CID). The parsing and understanding of various transaction input related information moved from the service to the validation crate. A lot of code was moved, some was deleted/renamed (specifically
EthRpctoChainInclusiontrait and the related inputs/outputs). TheChainInclusiontrait has an associated type for the input so chains without the same Eth RPC interface can request different information.