Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(react-16): migrate to new react version #604

Merged
merged 22 commits into from
Sep 20, 2022

Conversation

dubisdev
Copy link
Contributor

@dubisdev dubisdev commented Sep 17, 2022

We are migrating to react 16 (the goal is to migrate to the last React version).

DONE

  • Refactored some class components to functional components (07b5cb1, 8dfc73c. b9a2f63)
  • Removed preload and use useEffect (4f9669a)
  • Update react-markdow

BROKEN (Already fixed)

  • Some functionalities are broken due to the update. Once all components have been migrated to the new react version the logic will be easier to understand and they will be fixed.

Known issues:

  • React virtualized is not updating the results list and it is empty some times.

    View Image

    image

  • Select settings are not showing the value (but it still works)

    View Image

    image
    (search engine should appear but is missing)

Related PRs

We need to update related packages as cerebro-ui

Breaking changes

@dubisdev
Copy link
Contributor Author

Hi @oguhpereira

As this is going to be a big PR, it would be nice if you could start reviewing now.

@ogustavo-pereira ogustavo-pereira changed the title [WIP] chore: refactor to functional components [WIP] refactor(react-16): refactor to functional components Sep 19, 2022
@ogustavo-pereira
Copy link
Member

Everything working normally on linux

image

@dubisdev
Copy link
Contributor Author

I fixed the error with Selecting settings. Seems like they changed the API and I didn't saw the change for value prop
https://react-select.com/upgrade-to-v2#simple-value

@dubisdev
Copy link
Contributor Author

The error with react-virtualized is also fixed. I'll update some of the docs to make examples work with these breaking changes.

@dubisdev dubisdev changed the title [WIP] refactor(react-16): refactor to functional components perf(react-16): migrate to new react version Sep 20, 2022
@dubisdev dubisdev marked this pull request as ready for review September 20, 2022 20:58
@ogustavo-pereira ogustavo-pereira changed the title perf(react-16): migrate to new react version refactor(react-16): migrate to new react version Sep 20, 2022
@ogustavo-pereira ogustavo-pereira merged commit 1a1240b into master Sep 20, 2022
@dubisdev dubisdev deleted the migrate-react branch September 21, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants