Make uninstalling cert-manager SAFE: don't uninstal the CRDs #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
jetstack-bot
added
dco-signoff: yes
inteon
force-pushed
the
suppport_uninstalling_without_crds
branch
from
c061d02
to
c366f18
Compare
inteon
changed the title
jetstack-bot
removed
the
do-not-merge/work-in-progress
inteon
force-pushed
the
suppport_uninstalling_without_crds
branch
2 times, most recently
from
08a61d1
to
4e47223
Compare
This was referenced Feb 1, 2024
jetstack-bot
added
the
needs-rebase
inteon
force-pushed
the
suppport_uninstalling_without_crds
branch
from
4e47223
to
0ce0891
Compare
jetstack-bot
removed
the
needs-rebase
jetstack-bot
added
the
needs-rebase
inteon
force-pushed
the
suppport_uninstalling_without_crds
branch
from
0ce0891
to
e0eefb5
Compare
jetstack-bot
removed
the
needs-rebase
inteon
force-pushed
the
suppport_uninstalling_without_crds
branch
2 times, most recently
from
242852f
to
f79369c
Compare
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
inteon
force-pushed
the
suppport_uninstalling_without_crds
branch
from
f79369c
to
96c908b
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the uninstall command so it can be used to safely uninstall any cert-manager Helm chart without uninstalling the CRDs.
It does this by first updating the Helm release and adding the keep annotations to the CRDs, after which the uninstallation process continues.