Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linters #44

Merged
merged 15 commits into from
Apr 18, 2024
Merged

Fix linters #44

merged 15 commits into from
Apr 18, 2024

Conversation

inteon
Copy link
Member

@inteon inteon commented Mar 28, 2024 •
edited
Loading

Reduces the list of ignored linters by fixing the go code.

@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Mar 28, 2024
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from inteon. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 28, 2024
@inteon
fix usestdlibvars linter
21e32dc 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
fix unconvert linter
6e8377e 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
fix predeclared linter
d422a5a 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
fix gci linter
3de1be8 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
fix dupword linter
f8ec173 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2024
@inteon
fix unused linter
9d910fb 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
fix forbidigo linter
bfac6cf 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
fix gocritic linter
5631230 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
fix gosimple linter
07c0934 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
fix unparam linter
6a441ba 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
fix noctx linter
ed0f6e6 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
fix misspell linter
1c23a1d 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
fix nilerr linter
43248f9 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
fix staticcheck linter
ad6aa85 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon
fix errcheck linter
4156ca3 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
SgtCoDFish
SgtCoDFish approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

There's too much here to go through in a huge amount of detail but it's largely what I'd expect and if the tests pass I'm fine with it. Thanks!

internal/versionchecker/test/testdata/fetch.go
Comment on lines -378 to +379
var spec map[string]interface{}
var manifest map[string]interface{}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment (no action needed): I'm surprised there isn't a linter which suggests changing interface{} to any; I think it would provide a lot of benefit in this file. Wonder if there's a contribution opportunity there 🤔 Obviously unrelated to this PR though!

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2024
@cert-manager-prow cert-manager-prow bot merged commit cd7b918 into cert-manager:main Apr 18, 2024
5 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inteon @jetstack-bot @SgtCoDFish