Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in readme & add OWNERS file #13

Merged
merged 2 commits into from
May 26, 2023
Merged

Fix typo in readme & add OWNERS file #13

merged 2 commits into from
May 26, 2023

Conversation

inteon
Copy link
Member

@inteon inteon commented May 26, 2023 •
edited
Loading

I forgot to fix this typo: #7 (comment)
& the repo was still missing an OWNERS file.

@inteon
fix typo in readme
597b18d 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 26, 2023
@SgtCoDFish
Copy link
Member

suggest adding the OWNERS file here too!

@inteon
add OWNERS file
e2f4901 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon inteon changed the title Fix typo in readme Fix typo in readme & add OWNERS file May 26, 2023
@jetstack-bot jetstack-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 26, 2023
SgtCoDFish
SgtCoDFish approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

(Will add manual approval if required)

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2023
@SgtCoDFish SgtCoDFish added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: inteon, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 83446d3 into main May 26, 2023
@SgtCoDFish SgtCoDFish deleted the fix_typo branch May 26, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees

@SgtCoDFish SgtCoDFish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inteon @SgtCoDFish @jetstack-bot