-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move canonicalize logic to dedicated function #6
Conversation
…edit Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Definite improvement - I was gonna raise this myself if you'd not done it!
func (i KloneItem) Less(other KloneItem) bool { | ||
return i.FolderName < other.FolderName | ||
func (i KloneItem) Compare(other KloneItem) int { | ||
return strings.Compare(i.FolderName, other.FolderName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment: I actually read an interesting comment about strings.Compare
recently from the go source: https://github.com/golang/go/blob/e9b3ff15f40d6b258217b3467c662f816b078477/src/strings/compare.go#L14-L20
I don't think this needs to be changed, just highlighting it because I thought it was interesting!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR moves the canonicalize logic to a dedicated function and calls this function after reading the index file and before writing the index file.