Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update instructions in the Securing NGINX-ingress' tutorial #416

Closed
irbekrm opened this issue Jan 31, 2021 · 2 comments · Fixed by #421
Closed

Update instructions in the Securing NGINX-ingress' tutorial #416

irbekrm opened this issue Jan 31, 2021 · 2 comments · Fixed by #421
Assignees
@irbekrm
Labels
kind/documentation Categorizes issue or PR as related to documentation.

Comments

@irbekrm
Copy link
Contributor

irbekrm commented Jan 31, 2021

Last year Helm renamed the nginx-ingress chart to ingress-nginx kubernetes/ingress-nginx#5161

In the Securing NGINX-ingress tutorial we still use the deprecated nginx-ingress chart. We could update the instructions (and the screenshots) to use the ingress-nginx chart instead.

/kind documentation
@jetstack-bot
Copy link
Contributor

@irbekrm: The label(s) kind/ cannot be applied, because the repository doesn't have them

In response to this:

Last year Helm renamed the nginx-ingress chart to ingress-nginx kubernetes/ingress-nginx#5161

In the Securing NGINX-ingress tutorial we still use the deprecated nginx-ingress chart. We could update the instructions (and the screenshots) to use the ingress-nginx chart instead.

/kind documentation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Jan 31, 2021
@irbekrm
Copy link
Contributor Author

irbekrm commented Feb 2, 2021

/assign

@irbekrm irbekrm mentioned this issue Feb 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irbekrm irbekrm

Labels
kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Nginx ingress chart name is now ingress-nginx irbekrm/website
2 participants
@irbekrm @jetstack-bot