-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: TLSConfig secretName description #1419
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Diego Arce <diego@arce.cr>
21304ec
to
72d3d9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting this @arcezd
These docs are automatically generated from the cert-manager API
So we first need to create a cert-manager PR to fix the documentation there and then regenerate these pages.
Thanks for the clarification @wallrj, I just created the cert-manager PR 6785 with the changes, I guess we can close this one. |
Thanks @arcezd. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
On the
DynamicServingConfig
/TLSConfig
are specifying the samesecretNamespace
description for thesecretName
attribute.DynamicServingConfig