Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TLSConfig secretName description #1419

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arcezd
Copy link

@arcezd arcezd commented Feb 5, 2024

On the DynamicServingConfig/TLSConfig are specifying the same secretNamespace description for the secretName attribute.
DynamicServingConfig

@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 5, 2024
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jakexks for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented Feb 5, 2024

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 72d3d9b
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/65c1611107d4030007b37007
😎 Deploy Preview https://deploy-preview-1419--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Diego Arce <diego@arce.cr>
@arcezd arcezd force-pushed the fix-cert-manager-docs branch from 21304ec to 72d3d9b Compare February 5, 2024 22:28
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Feb 5, 2024
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this @arcezd

These docs are automatically generated from the cert-manager API

https://github.com/cert-manager/cert-manager/blob/a22d1d673ae8c16733ed342d4330eb5f5ab3f016/pkg/apis/config/webhook/v1alpha1/types.go#L102-L104

So we first need to create a cert-manager PR to fix the documentation there and then regenerate these pages.

@arcezd
Copy link
Author

arcezd commented Feb 22, 2024

Thanks for the clarification @wallrj, I just created the cert-manager PR 6785 with the changes, I guess we can close this one.
Thanks!

@wallrj
Copy link
Member

wallrj commented Feb 22, 2024

Thanks @arcezd.
Once that cert-manager PR merges, we will have to regenerate the API documentation here, using the scripts in scripts/.
So let's leave this open as a reminder.

@cert-manager-prow cert-manager-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2024
@cert-manager-prow
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants