Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge changes in master branch in to release-next branch #668

Merged
merged 30 commits into from
Aug 4, 2021

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Aug 4, 2021

Merged master in to release-next, so that the "next" docs are reasonably up to date for users of v1.5.0-beta.o

jdgri and others added 29 commits April 28, 2021 15:05
Signed-off-by: James Gilbert <jgilbert@akamai.com>
Signed-off-by: James Gilbert jgilbert@akamai.com
Signed-off-by: Maël Valais <mael@vls.dev>
Fixes cert-manager#652.

Signed-off-by: Martin Kröning <mkroening@posteo.net>
also contains other minor changes including grammar, removing trailing
whitespace and some small rewording.

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
Update certificate concepts doc, clarifying lack of root in tls.crt
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
suggested in cert-manager/cert-manager#4261

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
Note that I added an anchor ID using the syntax

  ## Header {#id}

That's to prevent anchor ID breakage, i.e., people have already copied
this anchor ID and expect the ID to still work.

Signed-off-by: Maël Valais <mael@vls.dev>
Two bits of information have also been added as part of this change: we
now explain that the app is expected to auto-reload the cert, and we
also added a word on the Venafi issuer not allowing reusing private keys
depending on the configuration.

Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
Co-authored-by: Ashley Davis <SgtCoDFish@users.noreply.github.com>
A note of caution about the use of ca.crt
Talk about key rotation downtime and "rotationPolicy: Always"
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
Signed-off-by: Maël Valais <mael@vls.dev>
…ersion-backup

While restoring a backup, the uid and resourceVersion should be ignored
FAQ Tweaks, Including Root Chain FAQ + Terminology
Signed-off-by: ryan.treat <ryan.treat@venafi.com>
Updates for Venafi as a Service
@jetstack-bot jetstack-bot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Aug 4, 2021
@jetstack-bot jetstack-bot added the dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. label Aug 4, 2021
@netlify
Copy link

netlify bot commented Aug 4, 2021

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: 580a212

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/610ab6ab2f44a0000704858d

😎 Browse the preview: https://deploy-preview-668--cert-manager-website.netlify.app

@jetstack-bot jetstack-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 4, 2021
@wallrj wallrj added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Aug 4, 2021
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@wallrj wallrj force-pushed the update-release-next branch from 6734094 to 580a212 Compare August 4, 2021 15:47
@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. and removed dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Aug 4, 2021
@jetstack-bot
Copy link
Contributor

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wallrj
Copy link
Member Author

wallrj commented Aug 4, 2021

/override dco

@jetstack-bot
Copy link
Contributor

@wallrj: Overrode contexts on behalf of wallrj: dco

In response to this:

/override dco

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wallrj wallrj added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Aug 4, 2021
@wallrj wallrj requested a review from maelvls August 4, 2021 16:16
Copy link
Member

@maelvls maelvls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2021
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2021
@jetstack-bot jetstack-bot merged commit d07d234 into cert-manager:release-next Aug 4, 2021
@wallrj wallrj deleted the update-release-next branch August 5, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants