-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge changes in master branch in to release-next branch #668
Merge changes in master branch in to release-next branch #668
Conversation
Signed-off-by: James Gilbert <jgilbert@akamai.com>
Signed-off-by: James Gilbert jgilbert@akamai.com
Signed-off-by: Maël Valais <mael@vls.dev>
Fixes cert-manager#652. Signed-off-by: Martin Kröning <mkroening@posteo.net>
also contains other minor changes including grammar, removing trailing whitespace and some small rewording. Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
Update certificate concepts doc, clarifying lack of root in tls.crt
DCO Sign Off: Fix broken link
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
Fix typo in supported releases
Update akamai.md
suggested in cert-manager/cert-manager#4261 Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
Note that I added an anchor ID using the syntax ## Header {#id} That's to prevent anchor ID breakage, i.e., people have already copied this anchor ID and expect the ID to still work. Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Maël Valais <mael@vls.dev>
Two bits of information have also been added as part of this change: we now explain that the app is expected to auto-reload the cert, and we also added a word on the Venafi issuer not allowing reusing private keys depending on the configuration. Signed-off-by: Maël Valais <mael@vls.dev> Co-authored-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Maël Valais <mael@vls.dev> Co-authored-by: Richard Wall <richard.wall@jetstack.io>
Signed-off-by: Maël Valais <mael@vls.dev>
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
Signed-off-by: Richard Wall <richard.wall@jetstack.io> Co-authored-by: Ashley Davis <SgtCoDFish@users.noreply.github.com>
A note of caution about the use of ca.crt
Talk about key rotation downtime and "rotationPolicy: Always"
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
Update artifacthub link
Signed-off-by: Maël Valais <mael@vls.dev>
…eases Update supported releases
…ersion-backup While restoring a backup, the uid and resourceVersion should be ignored
FAQ Tweaks, Including Root Chain FAQ + Terminology
Signed-off-by: ryan.treat <ryan.treat@venafi.com>
Updates for Venafi as a Service
✔️ Deploy Preview for cert-manager-website ready! 🔨 Explore the source changes: 580a212 🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/610ab6ab2f44a0000704858d 😎 Browse the preview: https://deploy-preview-668--cert-manager-website.netlify.app |
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
6734094
to
580a212
Compare
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/override dco |
@wallrj: Overrode contexts on behalf of wallrj: dco In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maelvls, wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged master in to release-next, so that the "next" docs are reasonably up to date for users of v1.5.0-beta.o