-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor to use vscode tabs #396
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Much more work needed as we are just selecting divs by id to show / hide. Need to properly move to a component based model.
If the screen becomes narrow show at least first letter and ...
The impl is still problematic and needs to be re worked to be a true web component.
This has been moved to a separate component.
Instead of manual handling the rendering etc. Also places the call tree in a vscode tab.
Instead of manual handling the rendering etc. Also places the call tree in a vscode tab.
Instead of manual handling the rendering etc. Also places the database view in a vscode tab.
Does not play nice with fast-elements
lcottercertinia
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More detailed changes
Type of change (check all applicable)
[optional] Any images / gifs / videos
Related Tickets & Documents
Related Issue #247
fixes #
resolves #58, resolves #249
closes #
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?