Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor to use vscode tabs #396

Merged
merged 28 commits into from
Sep 20, 2023

Conversation

lukecotter
Copy link
Contributor

@lukecotter lukecotter commented Sep 20, 2023

Description

More detailed changes

  • Switched to vscode toolkit panels
  • Refactor TreeView, CallTreeView, AnalysisView and DatabaseView into web components.

Type of change (check all applicable)

  • 🐛 Bug fix
  • ✨ New feature
  • ♻️ Refactor
  • ⚡ Performance Improvement
  • 📝 Documentation
  • 🔧 Chore
  • 💥 Breaking change

[optional] Any images / gifs / videos

image

Related Tickets & Documents

Related Issue #247
fixes #
resolves #58, resolves #249
closes #

Added tests?

  • 👍 yes
  • 🙅 no, not needed
  • 🙋 no, I need help

Added to documentation?

  • 🔖 README.md
  • 🔖 CHANGELOG.md
  • 📖 help site
  • 🙅 not needed

[optional] Are there any post-deployment tasks we need to perform?

Much more work needed as we are just selecting divs by id to show / hide.
Need to properly move to a component based model.
If the screen becomes narrow show at least first letter and ...
The impl is still problematic and needs to be
re worked to be a true web  component.
This has been moved to a separate component.
Instead of manual handling the rendering etc.
Also places the call tree in a vscode tab.
Instead of manual handling the rendering etc.
Also places the call tree in a vscode tab.
Instead of manual handling the rendering etc.
Also places the database view in a vscode tab.
Does not play nice with fast-elements
@lcottercertinia lcottercertinia merged commit 4d598b6 into certinia:main Sep 20, 2023
3 checks passed
@lukecotter lukecotter deleted the feat-vscode-tabs branch September 20, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New header bar feat: Can we use use vscode-webview-ui-toolkit to improve design consistency
2 participants