-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.1.2 default installation after instruction lacks dependencies for parsers/html_table #1499
Comments
Sorry for the accidental close, I mixed up the issue numbers -.- |
See also #552 Requires some changes in the core. The requirements of bots need to be defined somewhere |
intelmq 3.0.1 seems still have this issue.
|
Yes, it's the case for all bots which have specific additional requirements. |
This doesnt seems like a bug to me, because the error message should be clear enough. Maybe add some better error handling in intelmqctl and intelmq-manager if the error is MissingDependencyError. Would remove the bug label, as its not a bug. @sebix |
It's definitely bad usability. IIRC the reason I labelled this as bug was that this particular bot is part of the standard botnet. In other words: The default installation does not work without installing further dependencies. If you disagree, feel free to remove the label. intelmq/intelmq/etc/runtime.yaml Lines 60 to 65 in 469dc49
|
Feodotracker bots requires additional, heavy dependencies (beautifulsoup4) to start. Disabling them in the default conf allows us to ship the working config with the package without increase the dependencies required to install at the beginning. Fix: certtools#1499
I suggest disabling those bots in the default config. The bs4 is a heavy dependency, and I don't think it makes sense to ship it for everyone. We may find other alternative bots to present the duplicator usage, but so far, shipping not working config by default doesn't make any sense. |
Following v2.1.2 Install and Development instructions, then starting the example default bot net,
the feodo-tracker-browse-parser stopped with
Expectation: the instructions or the setup process should make sure that the dependencies for the standard bots are there.
Workaround on Ubuntu 18.04 LTS:
Idea: the intelmqctl check command should also check if dependencies can be loaded. Probably needs changes in the bots implementation.
The text was updated successfully, but these errors were encountered: