Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intelmqctl: Starting groups raises exception #2085

Closed
ghost opened this issue Aug 31, 2021 · 0 comments
Closed

intelmqctl: Starting groups raises exception #2085

ghost opened this issue Aug 31, 2021 · 0 comments
Labels
bug Indicates an unexpected problem or unintended behavior component: intelmqctl
Milestone

Comments

@ghost
Copy link

ghost commented Aug 31, 2021

On branch maintenance (and develop):

intelmq@localhost:~> intelmqctl start --group experts
Starting Expert group...
Traceback (most recent call last):
  File "/usr/local/bin/intelmqctl", line 33, in <module>
    sys.exit(load_entry_point('intelmq', 'console_scripts', 'intelmqctl')())
  File "/dev/intelmq/intelmq/bin/intelmqctl.py", line 1909, in main
    return x.run()
  File "/dev/intelmq/intelmq/bin/intelmqctl.py", line 1048, in run
    retval, results = args.func(**args_dict)
  File "/dev/intelmq/intelmq/bin/intelmqctl.py", line 1064, in bot_start
    return self.botnet_start(group=group)
  File "/dev/intelmq/intelmq/bin/intelmqctl.py", line 1152, in botnet_start
    bots = self._configured_bots_list(group=group)
  File "/dev/intelmq/intelmq/bin/intelmqctl.py", line 1141, in _configured_bots_list
    bots = sorted(k_v[0] for k_v in filter(lambda x: x[1]["group"] == BOT_GROUP[group], self.runtime_configuration.items()))
  File "/dev/intelmq/intelmq/bin/intelmqctl.py", line 1141, in <genexpr>
    bots = sorted(k_v[0] for k_v in filter(lambda x: x[1]["group"] == BOT_GROUP[group], self.runtime_configuration.items()))
  File "/dev/intelmq/intelmq/bin/intelmqctl.py", line 1141, in <lambda>
    bots = sorted(k_v[0] for k_v in filter(lambda x: x[1]["group"] == BOT_GROUP[group], self.runtime_configuration.items()))
KeyError: 'group'

The "global" block has no group and needs to be skipped here.

@ghost ghost added bug Indicates an unexpected problem or unintended behavior component: intelmqctl labels Aug 31, 2021
@ghost ghost added this to the 3.0.1 milestone Aug 31, 2021
@ghost ghost self-assigned this Aug 31, 2021
ghost pushed a commit that referenced this issue Aug 31, 2021
the global block of the runtime configuration was not excluded in one
block, raising an exception

fixes #2085
@ghost ghost closed this as completed in d21176c Sep 1, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: intelmqctl
Projects
None yet
Development

No branches or pull requests

0 participants