Splunk saved search expert bot #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no idea how to test this functionality without a Splunk instance filled with live data, so there are currently no tests. |
Add a parameter `overwrite` to the Splunk expert bot, having the same semantics as the `overwrite` argument to intelmq.message.Message.add().
ghost
self-assigned this
ghost
self-requested a review
ghost
added
component: bots
feature
ghost
suggested changes
Nov 26, 2020
Added. Note that the documentation is headlined "reports", and only mentions saved searches in passing. The terminology it uses is unclear, but a report is a presentation of the result of a saved search, with an optional schedule for running the saved search periodically. |
If an event arrives which lacks one of the fields set as a search parameter, log this as a warning and send the message on unmodified.
ghost
reviewed
Nov 30, 2020
ghost
suggested changes
Nov 30, 2020
Since this makes duplicate results impossible, disallow any other processing instructions for duplicates.
ghost
approved these changes
Dec 4, 2020
|
Thank you very much again! :) |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An expert bot that enriches events based on Splunk saved searches.