Remove malwardomains parser #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
schacht/2024-malwaredomainlist
branch
from
95fd2ab
to
df195bc
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2026 +/- ##
===========================================
- Coverage 76.07% 76.03% -0.05%
===========================================
Files 425 423 -2
Lines 22824 22777 -47
Branches 3023 3020 -3
===========================================
- Hits 17364 17319 -45
+ Misses 4754 4753 -1
+ Partials 706 705 -1
|
ghost
force-pushed
the
schacht/2024-malwaredomainlist
branch
2 times, most recently
from
642a2ae
to
457f329
Compare
ghost
reviewed
Aug 10, 2021
ghost
force-pushed
the
schacht/2024-malwaredomainlist
branch
2 times, most recently
from
b1bbfe6
to
b9c9efe
Compare
ghost
marked this pull request as ready for review
ghost
added
bug
ghost
suggested changes
Aug 10, 2021
ghost
force-pushed
the
schacht/2024-malwaredomainlist
branch
from
b9c9efe
to
77bf618
Compare
The malwaredomains.com website is down, therefore we remove the corresponding feed and parser. There were also some documentation examples that mentioned that parser, that were changed accordingly. The tests for the parser were removed and an upgrade function points out existing stale malwaredomains parser configurations to the users. Closes #2024
ghost
force-pushed
the
schacht/2024-malwaredomainlist
branch
from
77bf618
to
187ed14
Compare
ghost
approved these changes
Aug 11, 2021
|
Also cherry-picked for maintenance in 5c1ed4e |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The malwaredomains.com website is down, therefore we remove the
corresponding feed and parser. There were also some documentation
examples that mentioned that parser, that were changed accordingly.
The tests for the parser were removed and an upgrade function points out
existing stale malwaredomains parser configurations to the users.
Closes #2024