Implement a clear class hierarchy #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
schacht/implement_class_hierarchy
branch
3 times, most recently
from
84edadc
to
e552a68
Compare
ghost
added this to the
ghost
force-pushed
the
schacht/implement_class_hierarchy
branch
from
e552a68
to
329adcf
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2042 +/- ##
===========================================
+ Coverage 76.03% 76.05% +0.02%
===========================================
Files 430 432 +2
Lines 23111 23135 +24
Branches 3092 3092
===========================================
+ Hits 17572 17595 +23
- Misses 4832 4833 +1
Partials 707 707
|
ghost
force-pushed
the
schacht/implement_class_hierarchy
branch
13 times, most recently
from
4ead726
to
fc0200f
Compare
ghost
marked this pull request as ready for review
ghost
self-requested a review
ghost
force-pushed
the
schacht/implement_class_hierarchy
branch
from
fc0200f
to
31d40e2
Compare
ghost
suggested changes
Aug 18, 2021
ghost
force-pushed
the
schacht/implement_class_hierarchy
branch
from
31d40e2
to
ebe6fc1
Compare
ghost
reviewed
Aug 19, 2021
|
Could you please also update the dev guide (sections Template & Mixins are affected as I see with a quick search) |
ghost
force-pushed
the
schacht/implement_class_hierarchy
branch
from
ebe6fc1
to
d7a799d
Compare
ghost
approved these changes
Aug 23, 2021
added 3 commits
August 24, 2021 08:18
This commit replaces the SQLBot with an SQLMixin, which lets us use multiple inheritance with the bots.
This commit introduces an ExpertBot class that all expert bots should inherit from. To have a central place for storing the four types of bots there is now a datatypes module that contains an enum listing the four bot types. It can and should be used for more types that are part of the IntelMQ codebase. Also some output and parser bots were updated to depend on the correct bot type.
ghost
force-pushed
the
schacht/implement_class_hierarchy
branch
from
d7a799d
to
fe6a02c
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.