MS CTIP Azure feed invalid hostname filtering #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebix
added
bug
sebix
requested changes
Jan 27, 2022
Co-authored-by: Sebastian <sebix@sebix.at>
Codecov Report
@@ Coverage Diff @@
## develop #2144 +/- ##
========================================
Coverage 75.93% 75.93%
========================================
Files 440 440
Lines 23630 23633 +3
Branches 3439 3441 +2
========================================
+ Hits 17943 17946 +3
Misses 4956 4956
Partials 731 731
|
sebix
approved these changes
Jan 27, 2022
waldbauer-certat
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the CTIP Azure feed payload JSON section contains an IP address in
Payload.domain, which gets mapped intodestination.fqdn, but IP addresses are not valid FQDNs and hence said events are dumped. This PR adds explicit FQDN validation forPayload.domain, discarding invalid values.