Introduction of the Enabled-Switch for Collectors. #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces the enabled-switch for all Collector-Bots. By doing so it fixes certtools#715. The Collectorbot was extended with an own start-function which checks if the enabled paramter is present and was set to a representation of False. To check the "representation of False" the function to_bool was introduced in utils.py, which maps well-known-text to booleans. It has a a fallbackmode parameter which determines if the function returns true of false if no mapping was found. As long as to_bool does not evaluate to False the bot will be started.
sebix
added
feature
|
I pushed a generalized version to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the enabled-switch for all Collector-Bots.
By doing so it fixes #715.
The Collectorbot was extended with an own start-function
which checks if the enabled parameter is present and was set
to a representation of False. To check the "representation of
False" the function to_bool was introduced in utils.py, which
maps well-known-text to booleans. It has a a fallbackmode parameter
which determines if the function returns true of false if no
mapping was found.
As long as to_bool does not evaluate to False the bot will be started.