Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding get device info command #19

Merged

Conversation

rmeringe
Copy link

Adding the DeviceInfo Command to fetch the version and serial number from the yubi device

@rmeringe
Copy link
Author

@hendrikhofstadt bump whenever you get a chance please. Thanks!

1 similar comment
@rmeringe
Copy link
Author

@hendrikhofstadt bump whenever you get a chance please. Thanks!

@hendrikhofstadt
Copy link
Contributor

hendrikhofstadt commented Jun 22, 2022

Hi @rmeringe thanks a lot for your contribution. Could you please add support for the full response parsing? I'm aiming to keep this library complete for the supported commands.

Also please add a mention of the command support to the README

@hendrikhofstadt hendrikhofstadt self-requested a review June 22, 2022 10:13
@rmeringe
Copy link
Author

@hendrikhofstadt thanks for the response, sorry just getting back to this now but comments should be addressed

@hendrikhofstadt hendrikhofstadt merged commit 61ec924 into certusone:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants