Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix closing brace skips after a builtin conversion #575

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

QRPp
Copy link
Contributor

@QRPp QRPp commented Apr 19, 2021

Apply commit 6b14d7aa102aa3190362f2209d38c054eed85c46 from
https://github.com/cesanta/frozen, really.

Wasted a few hours chasing this already fixed bug anew, since
https://mongoose-os.com/docs/mongoose-os/api/core/frozen.h.md points at the
fixed source elsewhere rather than this mismaintained copy: what's the need for
it? Can't src/frozen be, e.g., a Git module-based Mongoose OS library?

Apply commit 6b14d7aa102aa3190362f2209d38c054eed85c46 from
https://github.com/cesanta/frozen, really.

Wasted a few hours chasing this already fixed bug anew, since
https://mongoose-os.com/docs/mongoose-os/api/core/frozen.h.md points at the
fixed source elsewhere rather than this mismaintained copy: what's the need for
it?  Can't src/frozen be, e.g., a Git module-based Mongoose OS library?
@rojer
Copy link
Collaborator

rojer commented Apr 19, 2021

sorry, this duplication of frozen code in mos is a problem. it should totally be moved out into a library, or made a module of the core library.

@rojer rojer merged commit 8c0c40a into cesanta:master Apr 19, 2021
@rojer
Copy link
Collaborator

rojer commented Apr 19, 2021

initially cesanta/mongoose-os was published from an internal repo, along with frozen and all the rest. frozen code was thus copied from the same master copy automatically and kept in sync that way. this publishing no longer happens, cesanta/mongoose-os is a fully independent repo and so for the time being frozen needs to be updated manually. as mentioned above, it should be made a module instead.

@rojer rojer mentioned this pull request Apr 19, 2021
@QRPp
Copy link
Contributor Author

QRPp commented Apr 19, 2021

Thanks. No divergent copy is top choice here, props for logging an issue. The inferior choice of having the doc point to the divergent copy of the source code would at least help specifically my problem (eye-debugging the fixed code). However that'd be counter-productive if the proper fix goes ahead.

@QRPp QRPp deleted the dont-skip-brace-after-builtin-conv branch April 19, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants