Better makie #262
Closed
Better makie #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move CUDA to an extension * fix CUDA deps * fix exports * no Requires * reformat toml * Ext * canonical * generalise copy_to_output * add the actual extension * fix
* add MakieOutput extension * bugfix atomics * fix atomics again * more cuda * bugfixes * cleanup
* update packages * add base dep versions * no toml test
* bugfixes * better messages * uncomment masking * chainstate fix * fix makie columns * bugfix gpu * better DD show
* Update boundaries.jl * Update boundaries.jl * Several changes (see descr) I added a test using Reflect(), update _inbounds for ::Reflect, bump Stencils to 0.3, and update index * Update simulationdata.jl * Update Project.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I'm hoping to fix a bunch of things with the MakieOutput to standardise workflows.
First, the objects returned as
framesshould always be the identical typed. This is so thatliftworks with no bugs.Sewcond, we should also always rebuild any
AbstractDimArrayinstead of passing a raw grid through to anyshowframemethod.Possibily, we should just use DimArray everywhere internally... but that has some compilation and complexity overheads. Maybe we can just rewrap them for any
GridRuleand output where users should actually interacti with the whole array rather than a single cell.