Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests & update to ex_machina #285

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Fix tests & update to ex_machina #285

merged 3 commits into from
Jul 12, 2023

Conversation

danielsp45
Copy link
Member

Some of the tests were failing duo to User fixtures being used in the tests, so I added ex-machina

ruilopesm
ruilopesm reviewed Jul 3, 2023
View reviewed changes
mix.exs Outdated Show resolved Hide resolved
ruilopesm
ruilopesm reviewed Jul 3, 2023
View reviewed changes
mix.exs Outdated Show resolved Hide resolved
ruilopesm
ruilopesm reviewed Jul 3, 2023
View reviewed changes
mix.exs Outdated Show resolved Hide resolved
ruilopesm
ruilopesm reviewed Jul 3, 2023
View reviewed changes
mix.exs Outdated Show resolved Hide resolved
ruilopesm
ruilopesm reviewed Jul 3, 2023
View reviewed changes
mix.exs Outdated Show resolved Hide resolved
@danielsp45 danielsp45 force-pushed the dp/fix-tests branch 2 times, most recently from 8845e91 to 9789a93 Compare July 3, 2023 22:41
@danielsp45 danielsp45 requested a review from ruilopesm July 3, 2023 22:42
@MarioRodrigues10
Copy link
Member

I think instead of doing a PR fixing user fixtures, you could fix all tests since you're already change a few of them, what you think?

@ruilopesm
Copy link
Member

ruilopesm commented Jul 4, 2023 •
edited
Loading

@MarioRodrigues10 We should leave tests for new comers to make 👀
It is a very good way to understand how the platform works.

@danielsp45 danielsp45 force-pushed the dp/fix-tests branch 5 times, most recently from b15ee6c to 4a4bda8 Compare July 10, 2023 17:11
@danielsp45 danielsp45 changed the title Fix user fixtures Fix tests & update to ex_machina Jul 10, 2023
@danielsp45 danielsp45 self-assigned this Jul 10, 2023
MarioRodrigues10
MarioRodrigues10 requested changes Jul 10, 2023
View reviewed changes
Copy link
Member

@MarioRodrigues10 MarioRodrigues10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also there's some inconsistency because you erased some live tests and kept others.

@MarioRodrigues10
Copy link
Member

Great work 🚀

@MarioRodrigues10 MarioRodrigues10 merged commit 500366b into develop Jul 12, 2023
1 check passed
@MarioRodrigues10 MarioRodrigues10 deleted the dp/fix-tests branch July 12, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarioRodrigues10 MarioRodrigues10 MarioRodrigues10 approved these changes

@ruioliveira02 ruioliveira02 Awaiting requested review from ruioliveira02

@ruilopesm ruilopesm Awaiting requested review from ruilopesm

@joaodiaslobo joaodiaslobo Awaiting requested review from joaodiaslobo

Assignees

@danielsp45 danielsp45

Labels
None yet
Projects
Atomic - Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielsp45 @MarioRodrigues10 @ruilopesm