feat: improve wheel #560
Merged
feat: improve wheel #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaodiaslobo
requested review from
Darguima,
tiago-bacelar,
EnzoVieira and
ruilopesm
There was a problem hiding this comment.
Nice. Since you're working on this though, could you pls do a couple extra things?
- The time delay is implemented inside api.js and that is driving me nuts. Can you please pull it out into Wheel.tsx?
- The token count is only updated after the 5 second delay. Could you also make it update before? Note that you can't run refetchUser, since that would already return any wins immediately, so instead you can just remove 20 tokens manually.
Also, you could have just put isSpinning inside canSpin() :)
MarioRodrigues10
requested changes
Oct 28, 2023
layout/Attendee/Wheel/Wheel.tsx
Outdated
| /> | ||
| ); | ||
| } else { | ||
| //TODO:: CHANGE THIS MESSAGE |
There was a problem hiding this comment.
Suggested change
| //TODO:: CHANGE THIS MESSAGE |
| <p className="font-ibold font-bold">SPIN THE WHEEL</p> | ||
| <p className="font-iregular">20 tokens💰</p> | ||
| <p className="select-none font-ibold font-bold">SPIN THE WHEEL</p> | ||
| <p className="select-none font-iregular">20 tokens💰</p> |
There was a problem hiding this comment.
This shouldn't be hardcoded but should be grapped from the safira environment, but do it in another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #535
Resolves #536