fix: reading reactInternals from null instance #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `onRenderCb` sets the `instance` after calling `getNode()`, which inside the `wrapAct` tries to access the `_reactInternals` property of `instance` (by that time `null`), thus raising `TypeError: Cannot read properties of null (reading '_reactInternals')`.
|
Hi, @sienic - great PR, I'll take a look at it 👍 |
|
I tried this while working to migrate a repo with hundreds of Enzyme tests to React 18. While I still have some failing tests (around not finding nodes it used to be able to find), this PR did successfully fix the |
|
Looks great @sienic . This will be hitting 0.7.0 later today. |
MonkeyDo
added a commit
to metabrainz/listenbrainz-server
that referenced
this pull request
Mar 10, 2023
This was a hacky way to resolve an issue with enzyme-adapter-react-18. Following a PR cfaester/enzyme-adapter-react-18#6 we shouldn't need to manually unmount the test wrappers anymore. Also see cfaester/enzyme-adapter-react-18#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
onRenderCbsets theinstanceaftergetNode()gets called, which inside thewrapActtries to access the_reactInternalsproperty ofinstance(by that timenull), thus raisingTypeError: Cannot read properties of null (reading '_reactInternals').