Update minimap version #1027
Merged
Update minimap version #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Donaim
force-pushed
the
update-minimap
branch
from
16ef7c0 to
ecfa6d8
Compare
Since minimap base algorithm changed between versions, this update requires setting the bw and bw_long options to retain the original behaviour. See lh3/minimap2#1124 for more details. Also, the quality calculation was adjusted in minimap. This is not a significant change for us because that quality metrics is not actually used anywhere.
Donaim
force-pushed
the
update-minimap
branch
from
ecfa6d8 to
089ef6d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## connect-minimap-hits #1027 +/- ##
=======================================================
Coverage ? 87.66%
=======================================================
Files ? 30
Lines ? 7174
Branches ? 0
=======================================================
Hits ? 6289
Misses ? 885
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since minimap base algorithm changed between versions, this update requires setting the bw and bw_long options to retain the original behaviour.
See lh3/minimap2#1124 for more details.