Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate scripts for uploading data to new repository #8

Closed
6 tasks done
donkirkby opened this issue Sep 8, 2014 · 4 comments
Closed
6 tasks done

Migrate scripts for uploading data to new repository #8

donkirkby opened this issue Sep 8, 2014 · 4 comments
Assignees
Milestone

Comments

@donkirkby
Copy link
Member

Issue #5 is going to require changes to the upload scripts, so I'm going to move them into this repository. My plan is to put upload_QC_data_for_pending_miseq_runs.pl into the root directory, and put the rest of the scripts in a modules folder. They should all accept a settings object from Settings.pm that the QC report scripts use.

  • Copy files from old repo to working folder, but don't commit.
  • Review files, looking for sensitive data or workstation-specific paths. Move them to the settings file.
  • Commit a broken version with minimal changes, just with sensitive things removed.
  • Restructure scripts to be modules and accept the settings object.
  • Test with some local data files uploading to test database, then commit.
  • Replace die error handling to create an error file, clear the run, and move to the next run (issue Just fail single run when SQL fails #16).
@donkirkby donkirkby mentioned this issue Sep 8, 2014
4 tasks
@donkirkby donkirkby self-assigned this Sep 8, 2014
donkirkby added a commit that referenced this issue Sep 12, 2014
These are basically unchanged from Eric's version, I just removed some
file paths and renamed the files to be modules.
donkirkby added a commit that referenced this issue Sep 12, 2014
Pass database connection to module methods.
DetermineReadBounds.pm merged into UploadSummaryValues.pm, and
upload_interop.pl merged into upload_QC_data_for_pending_miseq_runs.pl.
@donkirkby donkirkby modified the milestone: v1.0 Sep 16, 2014
@cbrumme
Copy link

cbrumme commented Oct 6, 2014

upload_QC_data_for_pending_miseq_runs.pl doesn't seem to have run for the latest MiSeq run (141001_M01841_0078_000000000-AB843)

There's no qc_uploaded or qc_error file in that folder.

@cbrumme cbrumme reopened this Oct 6, 2014
@donkirkby
Copy link
Member Author

I had left an old copy of the crontab commands lying around, and Conan used that when he changed the schedule recently. I have deleted that copy, and set the commands back to the commands listed in the contributing instructions.
The data should be uploaded at noon today, and the report rerun at 1pm.

@cbrumme
Copy link

cbrumme commented Oct 9, 2014

Still hasn't run as of noon on 9-Oct-2014

@cbrumme cbrumme reopened this Oct 9, 2014
@donkirkby
Copy link
Member Author

I made a mistake in the configuration. It's fixed and should run tomorrow at noon and 1pm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants