useLastItem() sometimes fails because item is undefined #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am also having this problem. I am having a difficult time reproducing it in CodePen, but in my local environment it is happening on pages where the content area is shorter vertically than the navigation bar (it’s got dozens of items and is extremely tall).
|
johnhunter
added a commit
to catehawke/distantsuncounselling.com
that referenced
this pull request
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a bug where in certain situations it'd break with an error. It seems to happen when searching for a string which has one result, adding another character so there are zero results, and then backspacing that character.
Anyway, it looks like the item passed to useLastItem is sometimes undefined. I'm not sure if there might be a better way to fix the root cause further up, but this at least stop its from failing.