-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async linting/.jshintrc config lookup #48
Conversation
For files outside the project root default config is used. For files inside the project, .jshintrc is looked up as node-cli jshint would.
Can you describe the .jshintrc look up changes a bit more? |
The main change is that there were no lookup before. It used to be that it could be located in the project root only. Now it could be located anywhere in the project root. It is especially useful if your project contains submodules. This is what JHint docs (see Configuration section) has to say:
Is this what you're looking for? As far as I know jshint (it's node-cli version) wouldn't stop at project root (because it does not have project, really). This version will not go any further (upper) than the project root. |
That sounds perfect - I just wanted to be sure I understood the change On Fri, May 9, 2014 at 9:37 AM, busykai notifications@github.com wrote:
Raymond Camden, Web Developer for Adobe Email : raymondcamden@gmail.com |
Async linting/.jshintrc config lookup
Thanks! :) If there will be issue reports, please let me know. I am watching this repo anyways, but just in case I miss something. |
Thank you - you have taken my simple extension and added about 99% of all On Fri, May 9, 2014 at 11:15 AM, busykai notifications@github.com wrote:
Raymond Camden, Web Developer for Adobe Email : raymondcamden@gmail.com |
Fixes #47.
@cfjedimaster, this PR passes JSHint extension to use async-linting and implements .jshintrc lookup (only within project root). Please take a look and test, I will continue my testing as well. Thanks!