Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for per-file directive overrides. #53

Merged
merged 2 commits into from
Jun 5, 2014
Merged

Add support for per-file directive overrides. #53

merged 2 commits into from
Jun 5, 2014

Conversation

D1SoveR
Copy link
Contributor

@D1SoveR D1SoveR commented May 27, 2014

JSHint has added support for overrides within .jshintrc file, as per jshint/jshint#1401.
Additional routine within the config loading procedure attempts to match this behaviour.

JSHint has added support for overrides within .jshintrc file, as per jshint/jshint#1401.
Additional routine within the config loading procedure attempts to match this behaviour.
@D1SoveR D1SoveR closed this May 29, 2014
@cfjedimaster
Copy link
Owner

Any reason you closed this? Do you not want me to merge it?

@D1SoveR
Copy link
Contributor Author

D1SoveR commented Jun 3, 2014

...oh. Genuinely, an accident. Must've mis-clicked somewhere in GitHub UI and not noticed it. Double-checked the implementation and still think it's worth merging, yeah. Follows the original JSHint implementation closely.

@D1SoveR D1SoveR reopened this Jun 3, 2014
Code still worked, as none of Object's default prototype bits are enumerable, but it would've broken if anything was added to it.
cfjedimaster added a commit that referenced this pull request Jun 5, 2014
Add support for per-file directive overrides.
@cfjedimaster cfjedimaster merged commit 1ef58cf into cfjedimaster:master Jun 5, 2014
@MuhammadTalhaArayain
Copy link

still i do not understand how can i use GITHUB, would anyone guide me.

@cfjedimaster
Copy link
Owner

Use GitHub for what?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants