Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for jshint extends option #54

Merged
merged 2 commits into from
Jun 2, 2014

Conversation

hacker112
Copy link
Contributor

Added the extends options according to: jshint/jshint#1314
Implemented in the cli.js of the command line version of jshint in loadConfig on line 532:

  if (config['extends']) {
    var baseConfig = exports.loadConfig(path.resolve(config.dirname, config['extends']));
    config.globals = _.extend({}, baseConfig.globals, config.globals);
    _.defaults(config, baseConfig);
    delete config['extends'];
  }

cfjedimaster added a commit that referenced this pull request Jun 2, 2014
Added support for jshint extends option
@cfjedimaster cfjedimaster merged commit 7721aa9 into cfjedimaster:master Jun 2, 2014
@cfjedimaster
Copy link
Owner

Thank you!

@hacker112
Copy link
Contributor Author

Well thank you for letting me participate :-)

@miqmago
Copy link

miqmago commented Oct 1, 2015

Cool option!
Is there any possibility to extend "jshint.globals" under "Debug > Open Preferences File" with this option?

I've tried with

{
    "extends": "",
    ...
}

with no success (in fact I'm getting Bad option: 'extends')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants