Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CFLint output engine consistent across all output formats #331

Open
TheRealAgentK opened this issue Jul 2, 2017 · 3 comments
Open
Assignees
Milestone

Comments

@TheRealAgentK
Copy link
Collaborator

Currently different output formats use different streams to create their format. Some of them use result marshallers, others manually create XML and then throw XSLT at it for Findbugs or HTML and JSON/TXT are written directly as a manual process.

I think the output engine needs a re-think for 2.0. I like the marshaller approach and I think we could probably pull all output systems into that architecture - which would clean up the current flow quite a bit.

@TheRealAgentK TheRealAgentK added this to the 2.0 milestone Jul 2, 2017
@TheRealAgentK TheRealAgentK self-assigned this Jul 2, 2017
@KamasamaK
Copy link
Collaborator

For the dev branch, the JSON format includes multiple new objects at the end of the same array as each issue. That does not appear to match the XML output's change, which does not use the issue tag but rather a new counts tag for that information. That should constitute a new object after the array, but that would also mean that the entire JSON output would be wrapped in an object now. I think that too would be consistent with the XML output.

@TheRealAgentK
Copy link
Collaborator Author

Answered in #323 - let's leave this ticket alone and move over there, #331 was really meant for me to internally rebuild the various output engines, not the formats of XML/JSON etc. I think the current discussion is better had in #323.

@TheRealAgentK
Copy link
Collaborator Author

TODO here, too:

Make sure we remove the limitation of only being able to create one of the XML-based formats only at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants