Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cflint ignore:line support for cfscript #741

Open
denuno opened this issue Aug 11, 2024 · 2 comments
Open

cflint ignore:line support for cfscript #741

denuno opened this issue Aug 11, 2024 · 2 comments
Assignees
@denuno
Labels
bug

Comments

@denuno
Copy link
Collaborator

denuno commented Aug 11, 2024

I should have looked closer, as I thought this was an existing test that was failing, but it looks like it was something I was in the process of addressing and never committed.
@denuno denuno added the bug label Aug 11, 2024
@denuno denuno self-assigned this Aug 11, 2024
@denuno
Copy link
Collaborator Author

denuno commented Aug 11, 2024

Oh, this test I had was actually about an empty config I guess, tho there was a bug with ignore:line as well… hmm

@denuno
Copy link
Collaborator Author

denuno commented Aug 12, 2024

was this the issue you meant to ask that on?

It looks like pre is not in the list of "phrasing content" so I guess it is invalid inside a p tag

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/p#technical_summary

denuno added a commit to denuno/CFLint that referenced this issue Aug 12, 2024
@denuno
add test with empty rule set and test for ignore:line fix
2b4775e 
this add the current source and a check for an ignore line where a bug is found
eventually we should maybe add the option of outputting the whole line in question so this is a start toward that
closes cflint#741
@denuno denuno mentioned this issue Aug 12, 2024
Merged
denuno added a commit that referenced this issue Aug 12, 2024
@denuno
add test with empty rule set and test for ignore:line fix (#742)
53a91bb 
closes #741
closes #743
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denuno denuno

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@denuno